Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract core logic #134

Open
Kikobeats opened this issue Aug 26, 2016 · 5 comments
Open

Extract core logic #134

Kikobeats opened this issue Aug 26, 2016 · 5 comments

Comments

@Kikobeats
Copy link
Contributor

Currently in this repository have logic very closed with docpress. For example, the logic related about determinate the JS/CSS files to load need to moved in core in favour to make more easy create different docpress themes.

@rstacruz
Copy link
Contributor

Makes sense. Any candidates for logic to be extracted aside from that?

On Sat, Aug 27, 2016, 12:32 AM Kiko Beats notifications@github.com wrote:

Currently in this repository have logic very closed with docpress. For
example, the logic related about determinate the JS/CSS files to load need
to moved in core in favour to make more easy create different docpress
themes.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#134, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEikTHOHlf3tQGxIlyhVWSdde45TEinks5qjv6OgaJpZM4JuKUL
.

@Kikobeats
Copy link
Contributor Author

google analytics should be a docpress plugin or docpress-core

@rstacruz
Copy link
Contributor

Hmmm.

Google Analytics needs to inject a JS snippet somewhere. Two ways I can think about how this can go:

  • put a plugin before docpress-base and insert it into ms.metadata().scripts
  • put a plugin after docpress-base and inject that script snippet

Indeed, the scripts / styles logic can be in docpress-core.

@Kikobeats
Copy link
Contributor Author

I think that the first point will be a good approach for make easy create other plugins, putting the share content inside meta

@rstacruz
Copy link
Contributor

I think that is best to do with injections. Like:

file.content = file.content.replace('', '...')

On Mon, Aug 29, 2016, 4:47 PM Kiko Beats notifications@github.com wrote:

I think that the first point will be a good approach for make easy create
other plugins, putting the share content inside meta


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#134 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEikajed_hPXtF0gFTtewkf0gaxT6dKks5qkpyvgaJpZM4JuKUL
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants