You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I submit a new UI bug. This bug affects all docpress versions until 0.7.1 (which is the latest version so far).
Description
Docpress use a div as a footer pagination mechanism for switching across pages. This div takes a class attribute with footer-nav value. The footer-nav div is fixed positioned to allow the div remain at the bottom of the page. When the screen width is less than 960px it overlaps with the markdown-body which contains the main page content. This results in some lines of texts to be hidden under footer-nav. This bug affects all the generated pages.
Steps to reproduce
Bellow I provide a reduced test case that highlight the bug.
Open responsive mode in developer console of your browser.
Change the width to less than 960px.
Scroll to the bottom of the page.
You'll see that the last paragraph does not end as expected and some text is missing.
Expected vs Actual Result
Expected Result
Actual Result
Proposal Fix
The reason that markdown-body is covered is that fixed position elements are removed from the document flow and do not take up any space. So markdown-body is ending at the bottom as if footer-nav isn't there. What we can do is use padding to take up space that would have been occupied by footer-nav as if it was in the normal flow. Something like this:
The value of padding-bottom property is equal to the height of footer-nav class.
I'll post a pull request immediately to fix that issue.
The text was updated successfully, but these errors were encountered:
GeorgeGkas
changed the title
markdown-body div is hidden under footer-nav on mobile devices
markdown-body div is hidden under footer-nav on mobile devices
Feb 2, 2018
This commit is intended to close issue: #244
Docpress use a div as a footer pagination mechanism for switching
across pages. This div takes a class attribute with `footer-nav`
value. The `footer-nav` div is fixed positioned to allow the div
remain at the bottom of the page. When the screen width is less
than *960px* it overlaps with the `markdown-body` which contains the
main page content. This results in some lines of texts to be
hidden under `footer-nav`. This bug affects all the generated pages.
To solve that issue we added `padding-bottom` css property to
`markdown-body` class to take up space that would have been occupied
by `footer-nav` as if it was in the normal flow.
I submit a new UI bug. This bug affects all docpress versions until 0.7.1 (which is the latest version so far).
Description
Docpress use a div as a footer pagination mechanism for switching across pages. This div takes a class attribute with
footer-nav
value. Thefooter-nav
div is fixed positioned to allow the div remain at the bottom of the page. When the screen width is less than 960px it overlaps with themarkdown-body
which contains the main page content. This results in some lines of texts to be hidden underfooter-nav
. This bug affects all the generated pages.Steps to reproduce
Bellow I provide a reduced test case that highlight the bug.
Expected vs Actual Result
Expected Result
Actual Result
Proposal Fix
The reason that
markdown-body
is covered is that fixed position elements are removed from the document flow and do not take up any space. Somarkdown-body
is ending at the bottom as iffooter-nav
isn't there. What we can do is use padding to take up space that would have been occupied byfooter-nav
as if it was in the normal flow. Something like this:The value of
padding-bottom
property is equal to the height offooter-nav
class.I'll post a pull request immediately to fix that issue.
The text was updated successfully, but these errors were encountered: