Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Azure OpenAI support with model switching #109

Merged
merged 16 commits into from
Oct 2, 2023

Conversation

janaka
Copy link
Contributor

@janaka janaka commented Sep 21, 2023

Description

Implements #10 #12

  • Adds support for multiple models to be configured and available concurrently.
  • Models can be selected from the available list in the settings UI
  • OpenAI, Azure OpenAI, and OptimumEmbedding BAAI/bge-small-en-v1.5 models included
  • OptimumEmbedding BAAI/bge-small-en-v1.5 runs locally and overall performs better than text-embedding-ada-002

WARNING: indexing with one embed model then switching to another requires a re-index.

Set default model settings collection from options available:
image

View details of the saved default model:
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor and code improvement (non-breaking change which improves code quality and/or performance)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • Tests
  • Other chores such as maintenance

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration by modifying the list below.

  • Test A
  • Test B
  • Test C

Test Configuration:

Please describe the test setup. List them below as bullet points.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • The commit message follows the convention of this project

@janaka janaka force-pushed the feat/hack/azure-openai-support branch from 5b8c9ee to 4c1c5d6 Compare September 25, 2023 15:07
@janaka janaka changed the title Feat(hack): Azure OpenAI support with model switching Feat: Azure OpenAI support with model switching Sep 27, 2023
@janaka janaka marked this pull request as ready for review September 27, 2023 16:06
@janaka janaka requested a review from a team as a code owner September 27, 2023 16:06
@janaka janaka force-pushed the feat/hack/azure-openai-support branch from 42790ae to 98a0d65 Compare September 28, 2023 10:48
@janaka janaka force-pushed the feat/hack/azure-openai-support branch from 41f5eca to c720dd1 Compare October 2, 2023 10:40
@janaka janaka linked an issue Oct 2, 2023 that may be closed by this pull request
@janaka janaka merged commit 7ad2aff into main Oct 2, 2023
3 checks passed
@janaka janaka deleted the feat/hack/azure-openai-support branch October 2, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORE: Settings for model selection
1 participant