Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: G Drive integration + integration docs improvements #218

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

janaka
Copy link
Contributor

@janaka janaka commented Feb 12, 2024

Description

Fixes/Implements #(issue/feature)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor and code improvement (non-breaking change which improves code quality and/or performance)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • Tests
  • Other chores such as maintenance

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration by modifying the list below.

  • Test A
  • Test B
  • Test C

Test Configuration:

Please describe the test setup. List them below as bullet points.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • The commit message follows the convention of this project

@janaka
Copy link
Contributor Author

janaka commented Feb 12, 2024

@osala-eng I merged your G Drive fix PR in main and then rebased this branch on main.

I think you haven't pushed the admin_section route fix?

I want to get this working in Prod tomorrow. So I need to have this working locally pls.

@osala-eng
Copy link
Contributor

@osala-eng I merged your G Drive fix PR in main and then rebased this branch on main.

I think you haven't pushed the admin_section route fix?

I want to get this working in Prod tomorrow. So I need to have this working locally pls.

I've pushed the fix for this #219

@janaka
Copy link
Contributor Author

janaka commented Feb 13, 2024

@osala-eng the fix got me futher but still getting an error after I choose which google account to link. All the config in the GCP identity and env vars on infisical should be fixed to have the correct redirect uri for localhost.

@osala-eng
Copy link
Contributor

@osala-eng the fix got me futher but still getting an error after I choose which google account to link. All the config in the GCP identity and env vars on infisical should be fixed to have the correct redirect uri for localhost.

Let me take a look

@osala-eng
Copy link
Contributor

All the setup seems okay, to use the service if the app is not yet verified you need to specify the list of allowed dev testers in GCP

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants