Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScriptUI Capitalization Consistency #12

Open
runegan opened this issue Jun 6, 2016 · 3 comments
Open

ScriptUI Capitalization Consistency #12

runegan opened this issue Jun 6, 2016 · 3 comments

Comments

@runegan
Copy link
Member

runegan commented Jun 6, 2016

Original report by vaporstack (Bitbucket: vaporstack, GitHub: vaporstack).


There are a couple of minor inconsistencies in the casing of ui/container.js -

Notably, AddEditText / AddStatictext have dissimilar casing. Easy enough to fix but probably should be done with a deprecation warning to avoid breaking existing scripts.

Recommend we use the naming and casing as described in JavaScript Tools Guide -

* AddStatictext -> AddStaticText
* AddTreeview -> AddTreeView
* AddListbox -> AddListBox* * 

A little bit annoying to decipher since the tools guide has some inconsistencies in itself, for example

#!javascript

 ProgressBar / Scrollbar
@runegan
Copy link
Member Author

runegan commented Jun 14, 2016

Original comment by Rune Gangsø (Bitbucket: runegan, GitHub: runegan).


How should the deprecation warning work? Just throw an error stating: "addListbox has changed name to addListBox"?

@runegan
Copy link
Member Author

runegan commented Sep 13, 2016

Original comment by Rune Gangsø (Bitbucket: runegan, GitHub: runegan).


ScriptUI Capitalization Consistency

See #12
I don't know if there is any more inconsistency, that needs to be checked.
The previous method names (addListbox, addStatictext and addTreeview)now points to the renamed methods (addListBox, addStaticText and addTreeView)
to be backwards compatible.

@runegan
Copy link
Member Author

runegan commented Apr 6, 2017

Original comment by Zack Lovatt (Bitbucket: zlovatt, GitHub: zlovatt).


Re: capitalization, there are also inconsistencies in the modules toString() functions;

return "[object aeq.App]"; compared to return "[object aeq.app]";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant