Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added asking whether to rewrite files #117

Merged
merged 9 commits into from
Aug 20, 2020
Merged

feat: Added asking whether to rewrite files #117

merged 9 commits into from
Aug 20, 2020

Conversation

sy-records
Copy link
Member

close #116

@sy-records sy-records requested review from anikethsaha and jamesgeorge007 and removed request for anikethsaha August 19, 2020 01:40
jthegedus
jthegedus approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anikethsaha
anikethsaha requested changes Aug 19, 2020
View reviewed changes
Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

optional : can we add a test for this ?

@sy-records
add tests
6448a4e
@sy-records
update
e580505 
fix ci

fix ci

fix ci
@sy-records sy-records merged commit f811906 into master Aug 20, 2020
@sy-records sy-records deleted the feat-116 branch August 20, 2020 10:11
@sy-records sy-records mentioned this pull request Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthegedus jthegedus jthegedus approved these changes

@anikethsaha anikethsaha anikethsaha approved these changes

@jamesgeorge007 jamesgeorge007 Awaiting requested review from jamesgeorge007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent docsify init ./docs from destroying existing initialization in that folder
4 participants
@sy-records @jthegedus @jamesgeorge007 @anikethsaha