Skip to content

Commit

Permalink
fix: Cannot read property 'tagName' of null (#1655)
Browse files Browse the repository at this point in the history
Have a look at this issue #1154 .
https://codesandbox.io/s/loving-matsumoto-hp985?file=/index.html
Open devtools and click the *blank space* of svg(not path) will reproduce this issue.

`parentNode` may be `null`.
https://github.com/docsifyjs/docsify/blob/develop/src/core/router/history/html5.js#L25-L27

However, hash router has fixed this issue😜.
https://github.com/docsifyjs/docsify/blob/develop/src/core/router/history/hash.js#L47-L49

Co-authored-by: 沈唁 <52o@qq52o.cn>
  • Loading branch information
woshiguabi and sy-records committed Oct 22, 2021
1 parent 57dc8a9 commit c3cdadc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/core/router/history/html5.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class HTML5History extends History {
on('click', e => {
const el = e.target.tagName === 'A' ? e.target : e.target.parentNode;

if (el.tagName === 'A' && !/_blank/.test(el.target)) {
if (el && el.tagName === 'A' && !/_blank/.test(el.target)) {
e.preventDefault();
const url = el.href;
// solve history.pushState cross-origin issue
Expand Down

1 comment on commit c3cdadc

@vercel
Copy link

@vercel vercel bot commented on c3cdadc Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.