Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bundle size from Docsify home page #1211

Open
trusktr opened this issue Jun 10, 2020 · 6 comments
Open

remove bundle size from Docsify home page #1211

trusktr opened this issue Jun 10, 2020 · 6 comments
Labels
good first Issue needs discussion website related to the official docsify website: https://docsify.js.org

Comments

@trusktr
Copy link
Member

trusktr commented Jun 10, 2020

Based on some other discussions we've had with @jhildenbiddle, we should perhaps remove the bundle size from the home page, and not worry so much about the size limit and moreso focus on what features make Docsify great.

My opinion: the current file size limit potential and awesome features from being introduced just because we're already at the file size limit.

@trusktr trusktr added discuss website related to the official docsify website: https://docsify.js.org good first Issue labels Jun 10, 2020
@jhildenbiddle
Copy link
Member

jhildenbiddle commented Jun 10, 2020

Perhaps focusing on other measures (like Lighthouse scores) would give the maintainers measurable targets and a better sense of overall performance for devs. Surprisingly, the current numbers for docsify.js.org aren't terrible. There's room to improve though, which we should prioritize for v5.

Screen Shot 2020-06-10 at 6 39 46 PM

FWIW, docsify-themeable fares better. It would be great to get these scores to 100 across the board if possible.

Screen Shot 2020-06-10 at 6 39 58 PM

(Note: The scores above were taken using the Lighthouse tab found Chrome's Dev Tools. A web version is also available at https://web.dev/measure/ but the "Performance" test encountered failed while auditing docsify-themeable's website.)

@anikethsaha
Copy link
Member

One thought,

We can add lighthouse in the CI ref.
That will help in reviewing PR so that we can increase the acceptance criteria of the PR.

@anikethsaha
Copy link
Member

We can pick each Points from the report can fix them.

@kirbyfern
Copy link
Contributor

kirbyfern commented Jun 29, 2020

In regards to the bundle size are you guys referring to this
Screenshot from 2020-06-29 15-46-05

and make it similar to https://simps.io/#/?
Screenshot from 2020-06-29 16-16-28

I would like to try and integrate lighthouse-ci

@anikethsaha
Copy link
Member

yes, thats the one.

I would like to try and integrate lighthouse-ci

great, feel free to do so,

@kirbyfern
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first Issue needs discussion website related to the official docsify website: https://docsify.js.org
Projects
None yet
Development

No branches or pull requests

4 participants