Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial push of lighthouse-ci & lighthous-ci-action #1259

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Initial push of lighthouse-ci & lighthous-ci-action #1259

wants to merge 1 commit into from

Conversation

kirbyfern
Copy link
Contributor

@kirbyfern kirbyfern commented Jul 1, 2020

Summary
This PR integrates Lighthouse CI and Lighthouse CI Action with Github Actions environment.
lighthouse-ci-action
lighthouse-ci
What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
    Maintainers have agreed upon implementing this feature
  • Related documents have been updated
  • Related tests have been updated

Wanted to see where this integration is at by initially pushing

@vercel
Copy link

vercel bot commented Jul 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/oobsz5i8l
✅ Preview: https://docsify-preview-git-fork-kirbygit-lighthouse-check.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 33c9ee4:

Sandbox Source
adoring-kirch-8zyft Configuration

Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Few question, why there are two actions ? can you explain what each one is doing ?
We need to test this against the new URL generated from the PR's change, not with docsify.js.org

Please refer this architecture. https://twitter.com/mikenikles/status/1272138850333327360

@kirbyfern
Copy link
Contributor Author

kirbyfern commented Jul 2, 2020

So far, what I understand is this:
lighthouse-ci shows a lighthouse report for every PR in the terminal while,
lighthouse-ci-action integrates with github actions and see failed test via the action interface within the docsify repo

Thus why there are two actions I made, I am still reading if it can be put into one action.

Thanks for the PR.

Few question, why there are two actions ? can you explain what each one is doing ?
We need to test this against the new URL generated from the PR's change, not with docsify.js.org

Please refer this architecture. https://twitter.com/mikenikles/status/1272138850333327360

Thanks I will read more about it, consider this as a draft PR.

@anikethsaha anikethsaha marked this pull request as draft July 2, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants