Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language-highlight.md #1263

Merged
merged 2 commits into from Jul 3, 2020
Merged

Conversation

jhildenbiddle
Copy link
Member

Proposed changes described in comment from #1251

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

Proposed changes described in comment from #1251
@vercel
Copy link

vercel bot commented Jul 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/54jygogaz
✅ Preview: https://docsify-preview-git-fix-docs-language-highlight.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cd9df2d:

Sandbox Source
dazzling-ptolemy-6r1j8 Configuration

Add PHP grammar file for Prism.js
Copy link
Member

@trusktr trusktr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Looks good. Do we want to add a note about differences between GitHub and Prism aliases?

@jhildenbiddle
Copy link
Member Author

I don’t think so, but if folks feel strongly about it I’m happy to add it.

Prism’s aliases are a subset of GitHub’s aliases (from what I’ve seen) and everything in our docs references Prism aliases. Point being, as long as people follow our docs, everything will work fine on GitHub. Plus, syntax highlighting is 1) not going to break anything if it doesn’t work and 2) pretty easy to spot when reviewing a social sight. Just my $0.02.

Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Feel free to merge it when ready

@jhildenbiddle jhildenbiddle merged commit 366500f into master Jul 3, 2020
@jhildenbiddle jhildenbiddle deleted the fix-docs-language-highlight branch July 3, 2020 16:23
@trusktr
Copy link
Member

trusktr commented Jul 3, 2020 via email

@sy-records sy-records mentioned this pull request Jul 12, 2020
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants