Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gitignore was ignoring folders in src… #1287

Merged
merged 2 commits into from Jul 16, 2020
Merged

fix: gitignore was ignoring folders in src… #1287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4c9247
fix: gitignore was ignoring folders in src, so VS Code search results…
trusktr Jul 16, 2020
e664a34
remove `lib` from pull request template as it is gitignored
trusktr Jul 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 1 addition & 8 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@
- [ ] Refactor
- [ ] Docs
- [ ] Build-related changes
- [ ] Repo settings
- [ ] Other, please describe:

If changing the UI of default theme, please provide the **before/after** screenshot:
Expand Down Expand Up @@ -44,11 +45,3 @@ If adding a **new feature**, the PR's description includes:
- [ ] Related tests have been updated

To avoid wasting your time, it's best to open a **feature request issue** first and wait for approval before working on it.


**Other information:**

---

* [ ] DO NOT include files inside `lib` directory.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason to keep this, it is listed in gitignore.


10 changes: 5 additions & 5 deletions .gitignore
View file
Open in desktop
Expand Up @@ -2,10 +2,10 @@
.DS_Store
.idea
node_modules
themes/
lib/
cypress/integration/examples
cypress/fixtures/docs
/themes/
/lib/
/cypress/integration/examples
/cypress/fixtures/docs

# exceptions
!.gitkeep
!.gitkeep