[fix #529] Search plugin: matched text is replaced with search text. #1304
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/5m41uvybl |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4d537a7:
|
| ); | ||
| }); | ||
|
|
||
| const matchContent = '...' + content + '...'; |
There was a problem hiding this comment.
when the title matched keyword, new Set(matchKeywords) will filte the matchKeywords == null.
when the postContent has more than one matched and the keyword has the same case, like testCase2.
search a keyword testDemo, and testDemo have more than one in `postContent`. Using new Set(matchKeywords) to remove the duplicated replaces from testDemo to <em class="search-keyword">testDemo</em>.
Koooooo-7
requested review from
anikethsaha,
jhildenbiddle,
sy-records and
trusktr
Koooooo-7
removed request for
trusktr,
jhildenbiddle,
anikethsaha and
sy-records
|
Due to #1298 more elegant to me, close here. |
Summary
Fix #529 Search plugin: matched text is replaced with search text.
Test Cases
testDemo
search keyword in title.
testCase1
normally,search a keyword testDemo.
testCase2
search a keyword testDemo, and testDemo have more than one in
postContent.testCase3
specially, TestDemo have difference case testDEMO in one
postContent.Results
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.