Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade marked #1798

Conversation

tgarciaalcala-godaddy
Copy link

@tgarciaalcala-godaddy tgarciaalcala-godaddy commented May 12, 2022

Summary

#1724
Docsify depends on an ancient version of marked which has some CVEs. The fix it to upgrade to marked v4.

What kind of change does this PR introduce?

Bugfix

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • [X ] Yes
  • No

If yes, please describe the impact and migration path for existing applications:
marked node dependency upgraded to version 4

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented May 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docsify-preview ✅ Ready (Inspect) Visit Preview May 12, 2022 at 8:25PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 12, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f21acb5:

Sandbox Source
docsify-template Configuration

@kinetifex
Copy link

Great to see this - I'm curious and concerned about the tests though. It seems like the changes around using playwright may be yielding false positives.

For example, I had started similar work against an older commit here, but integration tests fail locally catching the marked breaking changes from v3. So, I'm really surprised to see these test passing. I would expect more code changes to be required. For a specific example, this code.

Any insights here docsify team? It would be great to get marked updated to address the CVEs.

@tgarciaalcala-godaddy tgarciaalcala-godaddy changed the title Feat/synth 843 Upgrade marked May 23, 2022
@tgarciaalcala-godaddy
Copy link
Author

@kinetifex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants