Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signuppopup should go away after 'login' or 'signup' is clicked (with route change) #53

Closed
docsmage opened this issue Jul 7, 2016 · 1 comment
Assignees
Labels

Comments

@docsmage
Copy link
Owner

docsmage commented Jul 7, 2016

As of right now, clicking anywhere outside of signuppopup makes it disappear - however, taking action such as clicking 'signup' or 'login' currently does not send the modal away. This should not be the case.

Initial investigation into this issue lead me to http://stackoverflow.com/questions/23762323/is-there-a-way-to-automatically-close-angular-ui-bootstrap-modal-when-route-chan I attempted to implement the top solution by updating the .run statement in my app.js file. This did not work.

Next, I tried adding ng-click="closeModal()" to each URL in signuppopup.html, as in Sign up to save your mix! This also did not work, despite the fact that NavCtrl is the controller for that file, and that the closeModal function in NavCtrl appears to be written correctly according to the documentation provided by angular.

At this point I am stepping back from this issue to try fixing it again later. Submitting here to document my progress and also to separate it out as a different issue from issue #43.

@docsmage
Copy link
Owner Author

No longer relevant as login/save functionality has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant