Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SaveMix modal (savemixpopup) should go away when the user hits 'submit' #43

Closed
docsmage opened this issue Apr 20, 2016 · 2 comments
Closed

SaveMix modal (savemixpopup) should go away when the user hits 'submit' #43

docsmage opened this issue Apr 20, 2016 · 2 comments
Assignees
@docsmage
Labels
bug

Comments

@docsmage
Copy link
Owner

No description provided.

@docsmage docsmage self-assigned this Apr 20, 2016
@docsmage docsmage added the bug label Apr 20, 2016
@docsmage docsmage added this to the Debugging milestone Apr 20, 2016
@docsmage docsmage modified the milestones: Release 1.1, Debugging May 14, 2016
@docsmage docsmage changed the title After clicking somewhere in signuppopup, the popup should go away. After taking action within a popup, the popup should go away. May 14, 2016
docsmage added a commit that referenced this issue Jul 6, 2016
@docsmage
Working on Issue #43 - updated my version of angular and angular-ui-b…
65271dc 
…ootstrap, working off of documentation to properly implement close() method
docsmage added a commit that referenced this issue Jul 7, 2016
@docsmage
continued work on Issue #43 - added ngAnimate as dependency, experime…
c26bc4f 
…nted with using close() and dismiss() methods from modals documentation. Still cannot resolve issue.
@docsmage docsmage changed the title After taking action within a popup, the popup should go away. SaveMix modal (savemixpopup) should disappear when the user hits 'submit' Jul 7, 2016
@docsmage
Copy link
Owner Author

docsmage commented Jul 7, 2016 •
edited
Loading

I've investigated this issue extensively, it seems to be a known bug in Angular 1.4 as documented in this thread: angular-ui/bootstrap#3633

Here is the example for open(), close() and dismiss() given in the documentation: https://angular-ui.github.io/bootstrap/#/modal I attempted to adapt the example by adding ModalInstanceCtrl, but was ultimately not able to make it work. As of now the closeModal function in NavCtrl does nothing. This issue may be beyond my current abilities as a developer.

If an aspirational angular dev wants to get in and submit a potential resolution for this issue, I'm all for it. As of now I'm removing this issue from release 1.1. Also opened Issue #53 regarding the case with signuppopup, wherein it doesn't change if you click the links within the modal to change routes.

@docsmage docsmage mentioned this issue Jul 7, 2016
Closed
@docsmage docsmage changed the title SaveMix modal (savemixpopup) should disappear when the user hits 'submit' SaveMix modal (savemixpopup) should go away when the user hits 'submit' Jul 7, 2016
@docsmage docsmage modified the milestone: Release 1.1 Jul 7, 2016
@docsmage
Copy link
Owner Author

No longer relevant as login/save functionality has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@docsmage docsmage

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@docsmage