Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore redundant-decls warning on MinGW #235

Merged
merged 1 commit into from May 15, 2019
Merged

Ignore redundant-decls warning on MinGW #235

merged 1 commit into from May 15, 2019

Conversation

AMS21
Copy link
Contributor

@AMS21 AMS21 commented May 15, 2019

Description

What

Added warning suppression for -Wredundant-decls on MinGW.

Why

When compiling with MinGW and in your test file you include windows.h first and then doctest.h, you'll get this -Wredundant-decls warning. Another solution would be to include windows.h to silence the warning. But I think that wouldn't be preferable. Link to CI build displaying the Problem

GitHub Issues

N/A

@onqtam
Copy link
Member

onqtam commented May 15, 2019

Thanks for the fix! Strange that this doesn't happen in the doctest CI builds... Merging it.
Note that since this commit doesn't regenerate the final doctest.h this fix won't be immediately available in the dev branch. For regenerating the final header CMake must be invoked and a build should take place (there is a CMake custom command for that).

@onqtam onqtam merged commit b0e0574 into doctest:dev May 15, 2019
@AMS21 AMS21 deleted the patch-1 branch May 15, 2019 10:39
onqtam pushed a commit that referenced this pull request Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants