fix : including windows.h header cause error #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for this fix, as we had the exact same problem adding doctest support to ApprovalTest.cpp. The fix almost works - it just has a stray We suggest just changing |
claremacrae
added a commit
to approvals/ApprovalTests.cpp
that referenced
this pull request
Jul 29, 2019
https: //github.com/doctest/doctest/pull/258 Co-Authored-By: Llewellyn Falco <isidore@users.noreply.github.com>
|
Thank you for fixing it!!! |
|
@rinechran You're welcome, but we only fixed it in our copy of the doctest single header... It remains to be fixed in the master repo, so please could you re-open this issue? |
|
@claremacrae sorry I first tried to pull request and I accidentally closed the issue. |
|
thanks! |
onqtam
added a commit
that referenced
this pull request
Aug 5, 2019
onqtam
pushed a commit
that referenced
this pull request
Aug 11, 2019
onqtam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
includeing windows.h header caause error
because includeing std:: max will call max in windows.h.
GitHub Issues
Noting