Add support for compiling with clang-cl #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanDeMeyer
changed the title
DaanDeMeyer
changed the title
|
I also had to disable a few warnings to get everything (the examples) to compile without warnings. |
|
Turns out the warnings were already disabled somewhere else. I changed the logic to reuse that instead of disabling the same warnings twice. |
onqtam
reviewed
Sep 10, 2019
scripts/cmake/common.cmake
Outdated
| add_compiler_flags(-fstrict-aliasing) | ||
|
|
||
| # The following options are not valid when clang-cl is used. | ||
| if(UNIX) |
There was a problem hiding this comment.
I guess this check could be UNIX OR CMAKE_CXX_COMPILER_ID MATCHES "GNU" since we use MinGW on windows, or perhaps clang-cl could be excluded like this. But this is a minor nitpick so I could just merge this as it is.
There was a problem hiding this comment.
I did NOT MSVC which should handle all cases. It might be too extensive but we can solve that once we actually encounter issues with this approach.
onqtam
pushed a commit
that referenced
this pull request
Sep 22, 2019
jhasse
pushed a commit
to jhasse/doctest
that referenced
this pull request
Jan 28, 2021
- Addresses doctest#553, doctest#341, and doctest#286 - Edge shapes are now either one-sided or two-sided - Only one-sided edges support smooth collision and must be connected to other edges on both sides - Edge and chain shapes APIs updated to reflect changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic was adding GNU style command line flags when clang-cl was used which wants MSVC style command line flags. I've changed the logic to the same logic used in reproc to support clang-cl which fixes the issue.