Add -order-by=name to filter_2 test #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@onqtam I'll keep making pr's for now and letting CI run before merging so you can add comments and what not if needed. |
|
will wait for the builds before pushing - just in case |
The default -order-by=file order is compiler-dependent which currently causes the filter_2 test to fail depending on the compiler used. By using -order-by=name, the test always succeeds regardless of the compiler used. This commit also updates the filter_2_xml.txt test output to the new output produced by adding the -order-by=name option.
DaanDeMeyer
changed the title
onqtam
pushed a commit
that referenced
this pull request
Sep 22, 2019
The default -order-by=file order is compiler-dependent which currently causes the filter_2 test to fail depending on the compiler used. By using -order-by=name, the test always succeeds regardless of the compiler used. This commit also updates the filter_2_xml.txt test output to the new output produced by adding the -order-by=name option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default -order-by=file is compiler-dependent which currently causes the filter_2 test to fail depending on the compiler used. By using -order-by=suite, the test always succeeds regardless of the compiler used.
This PR also updates the filter_2_xml test output to the new output produced by adding the -order-by=suite option.
See #287