Fix GitHub CI and add GitHub build badges #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output was: At D:\a\_temp\384af4b7-bfae-4079-891c-d5392beae9ba.ps1:5 char:10 + cd build && ctest + ~~ The token '&&' is not a valid statement separator in this version. + CategoryInfo : ParserError: (:) [], ParseException + FullyQualifiedErrorId : InvalidEndOfLine I've split all 'cd build && ctest' lines, to avoid making future edits error-prone
The output was:
AIn file included from ../examples/all_features/main.cpp:2:
In file included from ../scripts/development_only\doctest/doctest.h:5:
../doctest/parts\doctest.cpp:142:10: error: non-portable path to file '<Windows.h>'; specified path differs in case from file name on disk [-Werror,-Wnonportable-system-include-path]
#include <windows.h>
^~~~~~~~~~~
<Windows.h>
1 error generated.
ninja: build stopped: subcommand failed.
Example output: xcode-select: error: invalid developer directory '/Applications/Xcode_10.2.1.app'
The output includes: The macOS virtual environment has been updated to Catalina (v10.15). Starting January 15th, jobs that include the line 'runs-on: macOS-10.14' will fail to run and return a failed check suite. Please update your workflow and change the line 'runs-on: macOS-10.14' to 'runs-on: macOS-latest'.
There are no longer available. See https://github.blog/changelog/2019-11-06-github-actions-macos-virtual-environment-updated-to-catalina/ which points to this: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/virtual-environments-for-github-hosted-runners Which says that these XCode versions are now available: 11.0, 11.1, 11.2, 11.2.1, 11.3
The currently-available versions are as follows, so pick the oldest and the newest of these. 11.0, 11.1, 11.2, 11.2.1, 11.3
11.0 does need to be specified to xcode-select as 11
|
Thanks for merging this!
Oh dear... I wonder what was different about the environments. I was only going on build failures in CI here, so am reasonably confident of the validity of the change, at least as of 12 days ago... Happily, this link shows that the GitHub CI build on the dev branch is now passing.... And hopefully it will pass on master will start passing whenever you next merge dev to master.... and then both will start showing up here: |
onqtam
pushed a commit
that referenced
this pull request
Feb 24, 2020
onqtam
added a commit
that referenced
this pull request
Jan 17, 2021
onqtam
added a commit
that referenced
this pull request
Jan 17, 2021
onqtam
added a commit
that referenced
this pull request
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the GitHub actions builds, so that any future breakages in them are easy to spot.
Changes made:
<Windows.h>to fix clang Windows buildsGitHub Issues