New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incomplete copy ctor #93

Merged

onqtam merged 1 commit into doctest:master from McMartin:remove-incomplete-copy-ctor

Oct 9, 2017

Contributor

McMartin commented Oct 8, 2017 •

edited

When making a copy of Expression_lhs, m_assert_type would be garbage.

This was caught by running clang-tidy on my own code.

third-party\doctest.h:1347:30: warning: The left operand of '&' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult]
            if(m_assert_type & assertType::is_false) //!OCLINT bitwise operator in conditional
                             ^


          Remove incomplete copy ctor

e5ba931

When making a copy of Expression_lhs, m_assert_type would be garbage.

onqtam merged commit b4b73f7 into doctest:master

McMartin deleted the remove-incomplete-copy-ctor branch

October 9, 2017 11:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment