This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
forked from Mapotempo/couchbase-orm
-
Notifications
You must be signed in to change notification settings - Fork 2
✨Handle strict_loading for model, record and relationship #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimpin
changed the title
Add red test on strict_loading for instance
(WIP) Add red test on strict_loading for model, record and relationship
May 9, 2023
pimpin
changed the title
(WIP) Add red test on strict_loading for model, record and relationship
(WIP) Handle strict_loading for model, record and relationship
May 9, 2023
pimpin
changed the title
(WIP) Handle strict_loading for model, record and relationship
✨Handle strict_loading for model, record and relationship
May 16, 2023
In current implementation, calling strict loading on a model will persist... ### this test pass (quite unexpectedly)
Child.strict_loading
expect_strict_loading_error_on_calling_parent(Child.where(id: child.id).strict_loading.first)
expect_strict_loading_error_on_calling_parent(Child.where(id: child.id).first)
expect_strict_loading_error_on_calling_parent(Child.where(id: child.id).last)
expect_strict_loading_error_on_calling_parent(Child.where(id: child.id).to_a.first)
expect_strict_loading_error_on_calling_parent(Child.all.to_a.first) |
Top 👍 |
DamienVoreiter
approved these changes
Jun 28, 2023
pimpin
added a commit
that referenced
this pull request
Dec 4, 2023
…ct_loading"" This reverts commit 8779129.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent N+1 request issue, enable strict_loading as done in ActiveRecord.
Exemple