Bugfix: UselessStatementLogger now warns when disable_ddl_transaction is called #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThHareau
added
the
ignore-for-release
ThHareau
commented
Jul 4, 2023
Comment on lines
-101
to
-102
| UselessStatementsLogger.warn_useless '`disable_ddl_transaction`' if super | ||
| true |
There was a problem hiding this comment.
Small bugfix here: this log was never sent because current_migration is not set yet
ThHareau
changed the title
ThHareau
added
bug
ThHareau
force-pushed
the
isolate-logger-in-module
branch
from
58824dd
to
d3d9a0d
Compare
EQuincerot
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only noticed the bug because I was refactoring logs (for a later PR) into a dedicated module, which is the main point of this PR