Supply --no-confirm when running bandcamp-dl command #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issues when releases on Bandcamp are set to private wich sometimes is the case when producers only release parts of albums as previews. In that case bancamp-dl run via MusicPlayerPlus will fail and all subsequent downloads will be skipped.
FIXME I'll open an issue describing the error. Sorry, it's been some time since the analysis and my fix to upstream...finally find the time to submit this.
Further notes:
The fix was added to the upstream project in
iheanyi/bandcamp-dl#205.
Release via PyPI is pending, thus I'll set this PR to draft and ask for notification by the upstream project.
Once that is through I'll set this PR to ready to merge. Hope that's fine!