Fix #1941 Change all string lengths to 191 chars

When using a multibyte character set such as utf8mb4, the character length goes from 255 to 191. This resolves errors such as “specified key was too long”
doctrine-extensions · Nov 9, 2019 · 41b8f14 · 41b8f14
1 parent 984adf6
commit 41b8f14
Show file tree

Hide file tree

Showing 20 changed files with 28 additions and 27 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,8 +19,9 @@ a release.
 ---
 
 ## [Unreleased]
-### Breaking Changes
-- Change `/lib/Gedmo` to `/src`
+### Notable & Breaking Changes
+- Source files moved from `/lib/Gedmo` to `/src`
+- All string column type annotations changed to 191 character length (#1941)
 
 ## [2.4.38] - 2019-11-08
 ### Global / Shared

diff --git a/src/Loggable/Entity/MappedSuperclass/AbstractLogEntry.php b/src/Loggable/Entity/MappedSuperclass/AbstractLogEntry.php
@@ -44,7 +44,7 @@ abstract class AbstractLogEntry
     /**
      * @var string $objectClass
      *
-     * @ORM\Column(name="object_class", type="string", length=255)
+     * @ORM\Column(name="object_class", type="string", length=191)
      */
     protected $objectClass;
 
@@ -65,7 +65,7 @@ abstract class AbstractLogEntry
     /**
      * @var string $data
      *
-     * @ORM\Column(length=255, nullable=true)
+     * @ORM\Column(length=191, nullable=true)
      */
     protected $username;
 

diff --git a/src/Translatable/Entity/MappedSuperclass/AbstractTranslation.php b/src/Translatable/Entity/MappedSuperclass/AbstractTranslation.php
@@ -30,7 +30,7 @@ abstract class AbstractTranslation
     /**
      * @var string $objectClass
      *
-     * @ORM\Column(name="object_class", type="string", length=255)
+     * @ORM\Column(name="object_class", type="string", length=191)
      */
     protected $objectClass;
 

diff --git a/tests/Gedmo/Blameable/Fixture/Entity/MappedSupperClass.php b/tests/Gedmo/Blameable/Fixture/Entity/MappedSupperClass.php
@@ -30,7 +30,7 @@ class MappedSupperClass
     * @var string $title
     *
     * @Gedmo\Translatable
-    * @ORM\Column(name="name", type="string", length=255)
+    * @ORM\Column(name="name", type="string", length=191)
     */
     protected $name;
 

diff --git a/tests/Gedmo/IpTraceable/Fixture/MappedSupperClass.php b/tests/Gedmo/IpTraceable/Fixture/MappedSupperClass.php
@@ -30,7 +30,7 @@ class MappedSupperClass
     * @var string $title
     *
     * @Gedmo\Translatable
-    * @ORM\Column(name="name", type="string", length=255)
+    * @ORM\Column(name="name", type="string", length=191)
     */
     protected $name;
 

diff --git a/tests/Gedmo/Loggable/Fixture/Entity/Address.php b/tests/Gedmo/Loggable/Fixture/Entity/Address.php
@@ -25,14 +25,14 @@ class Address
 
     /**
      * @var string $street
-     * @ORM\Column(type="string", length=255)
+     * @ORM\Column(type="string", length=191)
      * @Gedmo\Versioned()
      */
     protected $street;
 
     /**
      * @var string $city
-     * @ORM\Column(type="string", length=255)
+     * @ORM\Column(type="string", length=191)
      * @Gedmo\Versioned()
      */
     protected $city;

diff --git a/tests/Gedmo/Mapping/Driver/Xml/Mapping.Fixture.Xml.Embedded.dcm.xml b/tests/Gedmo/Mapping/Driver/Xml/Mapping.Fixture.Xml.Embedded.dcm.xml
@@ -5,7 +5,7 @@
 
     <embeddable name="Mapping\Fixture\Xml\Embedded">
 
-        <field name="subtitle" type="string" length="255" />
+        <field name="subtitle" type="string" length="191" />
     </embeddable>
 
 </doctrine-mapping>
diff --git a/tests/Gedmo/Mapping/Driver/Xml/Mapping.Fixture.Xml.EmbeddedTranslatable.dcm.xml b/tests/Gedmo/Mapping/Driver/Xml/Mapping.Fixture.Xml.EmbeddedTranslatable.dcm.xml
@@ -5,7 +5,7 @@
 
     <embeddable name="Mapping\Fixture\Xml\EmbeddedTranslatable">
 
-        <field name="subtitle" type="string" length="255">
+        <field name="subtitle" type="string" length="191">
             <gedmo:translatable/>
         </field>
     </embeddable>

diff --git a/tests/Gedmo/Sluggable/Fixture/Page.php b/tests/Gedmo/Sluggable/Fixture/Page.php
@@ -18,7 +18,7 @@ class Page
     private $id;
 
     /**
-     * @ORM\Column(type="string", length=255)
+     * @ORM\Column(type="string", length=191)
      */
     private $content;
 

diff --git a/tests/Gedmo/Sortable/Fixture/AbstractNode.php b/tests/Gedmo/Sortable/Fixture/AbstractNode.php
@@ -18,13 +18,13 @@ class AbstractNode
     protected $id;
 
     /**
-     * @ORM\Column(type="string", length=255)
+     * @ORM\Column(type="string", length=191)
      */
     protected $name;
 
     /**
      * @Gedmo\SortableGroup
-     * @ORM\Column(type="string", length=255)
+     * @ORM\Column(type="string", length=191)
      */
     protected $path;
 

diff --git a/tests/Gedmo/Sortable/Fixture/Category.php b/tests/Gedmo/Sortable/Fixture/Category.php
@@ -18,7 +18,7 @@ class Category
     private $id;
 
     /**
-     * @ORM\Column(type="string", length=255)
+     * @ORM\Column(type="string", length=191)
      */
     private $name;
 

diff --git a/tests/Gedmo/Sortable/Fixture/Event.php b/tests/Gedmo/Sortable/Fixture/Event.php
@@ -30,7 +30,7 @@ class Event
     /**
      * @var string
      *
-     * @ORM\Column(type="string", length=255)
+     * @ORM\Column(type="string", length=191)
      */
     private $name;
 

diff --git a/tests/Gedmo/Sortable/Fixture/Item.php b/tests/Gedmo/Sortable/Fixture/Item.php
@@ -18,7 +18,7 @@ class Item
     private $id;
 
     /**
-     * @ORM\Column(type="string", length=255)
+     * @ORM\Column(type="string", length=191)
      */
     private $name;
 

diff --git a/tests/Gedmo/Sortable/Fixture/SimpleListItem.php b/tests/Gedmo/Sortable/Fixture/SimpleListItem.php
@@ -18,7 +18,7 @@ class SimpleListItem
     private $id;
 
     /**
-     * @ORM\Column(type="string", length=255)
+     * @ORM\Column(type="string", length=191)
      */
     private $name;
 

diff --git a/tests/Gedmo/Sortable/Fixture/Transport/Reservation.php b/tests/Gedmo/Sortable/Fixture/Transport/Reservation.php
@@ -26,7 +26,7 @@ class Reservation
      * Bus destination
      *
      * @Gedmo\SortableGroup
-     * @ORM\Column(length=255)
+     * @ORM\Column(length=191)
      */
     private $destination;
 
@@ -43,7 +43,7 @@ class Reservation
     private $seat;
 
     /**
-     * @ORM\Column(length=255)
+     * @ORM\Column(length=191)
      */
     private $name;
 

diff --git a/tests/Gedmo/Timestampable/Fixture/MappedSupperClass.php b/tests/Gedmo/Timestampable/Fixture/MappedSupperClass.php
@@ -30,7 +30,7 @@ class MappedSupperClass
     * @var string $title
     *
     * @Gedmo\Translatable
-    * @ORM\Column(name="name", type="string", length=255)
+    * @ORM\Column(name="name", type="string", length=191)
     */
     protected $name;
 

diff --git a/tests/Gedmo/Translatable/Fixture/CompanyEmbedLink.php b/tests/Gedmo/Translatable/Fixture/CompanyEmbedLink.php
@@ -13,15 +13,15 @@ class CompanyEmbedLink
     /**
      * @var string
      *
-     * @ORM\Column(name="website", type="string", length=255, nullable=true)
+     * @ORM\Column(name="website", type="string", length=191, nullable=true)
      * @Gedmo\Translatable
      */
     protected $website;
 
     /**
      * @var string
      *
-     * @ORM\Column(name="facebook", type="string", length=255, nullable=true)
+     * @ORM\Column(name="facebook", type="string", length=191, nullable=true)
      * @Gedmo\Translatable
      */
     protected $facebook;
@@ -64,4 +64,4 @@ public function setFacebook($facebook)
         return $this;
     }
 
-}
+}
diff --git a/tests/Gedmo/Tree/Fixture/Genealogy/Person.php b/tests/Gedmo/Tree/Fixture/Genealogy/Person.php
@@ -55,7 +55,7 @@ abstract class Person
   private $lvl;
 
   /**
-   * @ORM\Column(name="name", type="string", length=255, nullable=false)
+   * @ORM\Column(name="name", type="string", length=191, nullable=false)
    * @var string
    */
   private $name;

diff --git a/tests/Gedmo/Tree/Fixture/Role.php b/tests/Gedmo/Tree/Fixture/Role.php
@@ -55,7 +55,7 @@ abstract class Role
   private $lvl;
 
   /**
-   * @ORM\Column(name="role", type="string", length=255, nullable=false)
+   * @ORM\Column(name="role", type="string", length=191, nullable=false)
    * @var string
    */
   private $role;

diff --git a/tests/Gedmo/Tree/Fixture/UserGroup.php b/tests/Gedmo/Tree/Fixture/UserGroup.php
@@ -12,7 +12,7 @@
 class UserGroup extends Role
 {
     /**
-   * @ORM\Column(name="name", type="string", length=255)
+   * @ORM\Column(name="name", type="string", length=191)
    * @var string
    */
   private $name;