PHP 8+: Support for attributes

[makraz]

What are your plans for PHP 8+?
Is there any WIP about mapping attributes so we could use #[ORM\Column] instead of /** @var ORM\Column */?
If not, I'll like to work on this.

[ndench]

I'd love to see this. I currently can't migrate to #[ORM\Column] because the extensions won't detect the properties anymore. Let me know if there's anything I can do to help.

[fridde]

@makraz You might want to edit your title to "PHP 8+: Support for attributes" since I initially thought you were missing some special attribute when in fact you wish for attributes to be supported at all.

Good initiative!

[makraz]

Thanks @fridde for the feedback

[bpolaszek]

I'd love to see this. I currently can't migrate to #[ORM\Column] because the extensions won't detect the properties anymore. Let me know if there's anything I can do to help.

/**
 * @Gedmo\Timestampable(on="create")
 */
#[ORM\Column(type: Types::DATETIMETZ_IMMUTABLE)]
public \DateTimeImmutable $createdAt;

Not elegant, but works on my side.

[fridde]

@bpolaszek Woah, for some reason I didn't realize that we could mix annotations and attributes. I thought that Gedmo would use the system I declared in doctrine.yaml with the setting for doctrine.orm.mappings.App.type (which I set to "attribute").

Thanks for pointing out this workaround. This will be useful during the transition.

[ndench]

That's a good workaround @bpolaszek. Unfortunately it doesn't work for blameable because the BlameableListener uses doctrine annotations to determine if the property is an association.

DoctrineExtensions/src/Blameable/BlameableListener.php

Line 29 in 0bce650

if ($meta->hasAssociation($field)) {

[scroach]

That's a good workaround @bpolaszek. Unfortunately it doesn't work for blameable because the BlameableListener uses doctrine annotations to determine if the property is an association.

DoctrineExtensions/src/Blameable/BlameableListener.php

Line 29 in 0bce650

if ($meta->hasAssociation($field)) {

Why shouldn't this work? The BlameableListener works on the ClassMetadata provided by doctrine so it should not matter how you mapped your fields.

Anyway I would definitely favor having attributes, I try to prevent mixing annotations and attributes.

[knojector]

I'd love to see this. I currently can't migrate to #[ORM\Column] because the extensions won't detect the properties anymore. Let me know if there's anything I can do to help.

/**
 * @Gedmo\Timestampable(on="create")
 */
#[ORM\Column(type: Types::DATETIMETZ_IMMUTABLE)]
public \DateTimeImmutable $createdAt;

Not elegant, but works on my side.

Hi @bpolaszek,
I ran into the same issue but unfortunately the date fields are always populated with null. Do I need to adjust my doctrine.yml in order to mix attributes and annotations? This is my current mapping configuration:

mappings:
    App:
        type: attribute
        dir: '%kernel.project_dir%/src/Entity/'
        prefix: 'App\Entity\'

Edit:
Could figure it out... I switched from the stof/doctrine-extensions-bundle to this bundle and just missed to register the timestampable service manually in my services.yml.

gedmo.listener.timestampable:
    class: Gedmo\Timestampable\TimestampableListener
    tags:
        - { name: doctrine.event_subscriber, connection: default }
    calls:
        - [ setAnnotationReader, [ "@annotation_reader" ] ]

[franmomu]

Support for ORM attribute mapping was added in 3.2, I'm closing this one in favor of #2363 where we can keep track of the needed work, any help is welcome!