[Tree] The value of path source property is cast to string type #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aterialized Path Tree strategy
andreybotanic
approved these changes
Nov 29, 2019
|
Hi @AkenRoberts! I'm sorry for bothering you but what do I need to do to review this MR? Looks like the CI failure doesn't relate to the MR. |
|
@AkenRoberts Could this be looked at? it seems Travis fails due to a config error of Travis and not due to an error made by @kosarinin |
MisatoTremor
approved these changes
Jan 16, 2020
|
Thank you. ❤️ |
AkenRoberts
pushed a commit
that referenced
this pull request
Jan 18, 2020
…aterialized Path Tree strategy Cherry picked from 2.4.x branch. #2061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! During the migration to php7.4, we faced with an error. We use integer value as a tree path source and it causes this error:
on this line https://github.com/Atlantic18/DoctrineExtensions/blob/81681364331b131518060e4776300a5346df1eb5/lib/Gedmo/Tree/Strategy/AbstractMaterializedPath.php#L299