New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make users add mapping to tree closure entities #2390
Conversation
8a74332
to
d52d962
Compare
Codecov Report
@@ Coverage Diff @@
## main #2390 +/- ##
============================================
+ Coverage 80.83% 80.89% +0.06%
- Complexity 3137 3148 +11
============================================
Files 159 159
Lines 8102 8140 +38
============================================
+ Hits 6549 6585 +36
- Misses 1553 1555 +2
Continue to review full report at Codecov.
|
b992860
to
a99fbff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, if this PR fixes some bugs, we should add a "Fixed" entry in the changelog.
a99fbff
to
5df80fb
Compare
5df80fb
to
164c231
Compare
164c231
to
5ab77e5
Compare
Thanks @franmomu! |
In #58 one of the solution was to make the user to map the associations manually.
Fixes #2236 and probably #2240
This PR supersedes #2370