Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make users add mapping to tree closure entities #2390

Merged
merged 1 commit into from Dec 30, 2021

Conversation

franmomu
Copy link
Collaborator

In #58 one of the solution was to make the user to map the associations manually.

Fixes #2236 and probably #2240

This PR supersedes #2370

@franmomu franmomu added the Tree label Dec 27, 2021
@franmomu franmomu mentioned this pull request Dec 27, 2021
@franmomu franmomu force-pushed the tree_closure branch 4 times, most recently from 8a74332 to d52d962 Compare December 27, 2021 09:54
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2021

Codecov Report

Merging #2390 (5ab77e5) into main (3e372a5) will increase coverage by 0.06%.
The diff coverage is 95.74%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2390      +/-   ##
============================================
+ Coverage     80.83%   80.89%   +0.06%     
- Complexity     3137     3148      +11     
============================================
  Files           159      159              
  Lines          8102     8140      +38     
============================================
+ Hits           6549     6585      +36     
- Misses         1553     1555       +2     
Impacted Files Coverage Δ
src/Tree/Strategy/ORM/Closure.php 97.43% <95.74%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e372a5...5ab77e5. Read the comment docs.

@franmomu franmomu changed the title Make users to add mapping to tree closure tables Make users add mapping to tree closure tables Dec 27, 2021
@franmomu franmomu force-pushed the tree_closure branch 2 times, most recently from b992860 to a99fbff Compare December 27, 2021 12:34
@franmomu franmomu changed the title Make users add mapping to tree closure tables Make users add mapping to tree closure entities Dec 27, 2021
Copy link
Collaborator

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, if this PR fixes some bugs, we should add a "Fixed" entry in the changelog.

@phansys phansys merged commit 13dd920 into doctrine-extensions:main Dec 30, 2021
@phansys
Copy link
Collaborator

phansys commented Dec 30, 2021

Thanks @franmomu!

@franmomu franmomu deleted the tree_closure branch December 30, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class ... has no association named descendant
3 participants