Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow symfony 7 #2721

Merged
merged 12 commits into from
Dec 3, 2023

Conversation

Chris53897
Copy link
Contributor

Test-Runs will probably not cover a test for 7.0.x-dev

I guess the best idea is to wait until a stable releae of 7.0 and rerun ci.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (922e6b2) 79.27% compared to head (c26d494) 79.33%.
Report is 1 commits behind head on main.

❗ Current head c26d494 differs from pull request most recent head 5982b16. Consider uploading reports for the commit 5982b16 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2721      +/-   ##
==========================================
+ Coverage   79.27%   79.33%   +0.06%     
==========================================
  Files         162      162              
  Lines        8467     8460       -7     
==========================================
  Hits         6712     6712              
+ Misses       1755     1748       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VincentLanglet
Copy link
Contributor

Hi @Chris53897

You could add composer config minimum-stability RC in the CI to test SF7
Maybe the install will be block by some other dependencies and the sooner we know the better we can solve them.

@Chris53897
Copy link
Contributor Author

@VincentLanglet I followed your advice.
But i do not know how to restrict these to symfony 7. As the CI does not force checks for symfony versions.
It is finde for testing now, but should be removed later on.

symfony/translation is pinned to 6.4. But support for symfony 7 look good according to ci.

@VincentLanglet
Copy link
Contributor

VincentLanglet commented Nov 27, 2023

We have

 Locking symfony/cache (v7.0.0-RC2)
  - Locking symfony/cache-contracts (v3.4.0)
  - Locking symfony/config (v7.0.0-RC1)
  - Locking symfony/console (v7.0.0-RC2)
  - Locking symfony/dependency-injection (v7.0.0-RC1)
  - Locking symfony/deprecation-contracts (v3.4.0)
  - Locking symfony/doctrine-bridge (v7.0.0-RC2)
  - Locking symfony/error-handler (v7.0.0-RC1)
  - Locking symfony/event-dispatcher (v7.0.0-RC1)
  - Locking symfony/event-dispatcher-contracts (v3.4.0)
  - Locking symfony/filesystem (v7.0.0-RC1)
  - Locking symfony/finder (v7.0.0-RC1)
  - Locking symfony/framework-bundle (v7.0.0-RC2)
  - Locking symfony/http-foundation (v7.0.0-RC1)
  - Locking symfony/http-kernel (v7.0.0-RC2)
  - Locking symfony/phpunit-bridge (v6.4.0-RC1)
  - Locking symfony/polyfill-ctype (v1.28.0)
  - Locking symfony/polyfill-intl-grapheme (v1.28.0)
  - Locking symfony/polyfill-intl-normalizer (v1.28.0)
  - Locking symfony/polyfill-mbstring (v1.28.0)
  - Locking symfony/polyfill-php72 (v1.28.0)
  - Locking symfony/polyfill-php80 (v1.28.0)
  - Locking symfony/polyfill-php81 (v1.28.0)
  - Locking symfony/polyfill-php83 (v1.28.0)
  - Locking symfony/routing (v7.0.0-RC1)
  - Locking symfony/service-contracts (v3.4.0)
  - Locking symfony/string (v7.0.0-RC2)
  - Locking symfony/translation (v6.4.0-RC2)
  - Locking symfony/translation-contracts (v3.4.0)
  - Locking symfony/var-dumper (v7.0.0-RC2)
  - Locking symfony/var-exporter (v7.0.0-RC2)
  - Locking symfony/yaml (v7.0.0-RC1)

So indeed SF7 is installed.

We could try to understand why translation is still 6.4.0 with something like

composer why-not symfony/translation v7.0.0-RC2

And you should change

"symfony/phpunit-bridge": "^6.0",

to

"symfony/phpunit-bridge": "^6.0 || ^7.0",

@Chris53897
Copy link
Contributor Author

Problem: nesbot/carbon v3 is not yet been released.
https://packagist.org/packages/nesbot/carbon#3.x-dev

Wait for a stable release?
To solve it temporary i changed it to "nesbot/carbon": "^2.71 || 3.x-dev as 3.0",

@VincentLanglet
Copy link
Contributor

VincentLanglet commented Nov 27, 2023

Indeed ; but that's not a big deal since it's a dev dependency so it won't impact user of the doctrine-extensions lib.
I would say that with this green build we can confirm that doctrine-extensions support SF7.

IMHO you can revert the change in /continuous-integration.yml
and a reelase could be done with support for SF7.

Co-authored-by: Vincent Langlet <VincentLanglet@users.noreply.github.com>
@VincentLanglet
Copy link
Contributor

If you can take a look @franmomu @phansys, this would be awesome to have a release with this :)

@tacman
Copy link
Contributor

tacman commented Nov 29, 2023

Symfony 7 is out now, I'm happy to test!

@franmomu franmomu merged commit 1b31c3a into doctrine-extensions:main Dec 3, 2023
16 checks passed
@franmomu
Copy link
Collaborator

franmomu commented Dec 3, 2023

thanks @Chris53897!

@Chris53897 Chris53897 deleted the feature/allow-symfony-7 branch December 3, 2023 08:58
paxal pushed a commit to sportmium/DoctrineExtensions that referenced this pull request Mar 18, 2024
* feat: allow symfony 7

* feat: allow symfony 7

* feat: allow symfony 7

* feat: allow symfony 7

* feat: allow symfony 7

* feat: allow symfony 7

* feat: allow symfony 7

* feat: allow symfony 7

* feat: allow symfony 7

* Update .github/workflows/continuous-integration.yml

Co-authored-by: Vincent Langlet <VincentLanglet@users.noreply.github.com>

* Empty-Commit

---------

Co-authored-by: Christopher Georg <christopher.georg@sr-travel.de>
Co-authored-by: Vincent Langlet <VincentLanglet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants