Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

driverOptions is missing from $params starting in 2.6.3 #1541

Closed
nesl247 opened this issue Jun 21, 2022 · 3 comments
Closed

driverOptions is missing from $params starting in 2.6.3 #1541

nesl247 opened this issue Jun 21, 2022 · 3 comments
Labels
Won't Fix

Comments

@nesl247
Copy link

nesl247 commented Jun 21, 2022 •
edited
Loading

#1506 removed driverOptions from the exclusion of the param rewrite. Because of this, extensions like https://github.com/facile-it/doctrine-mysql-come-back broke.

I would consider this a BC break.
@ostrolucky
Copy link
Member

What's your opinion on this issue @simPod?

@simPod
Copy link
Contributor

simPod commented Jun 22, 2022

I'm not BC breaking guru, not sure how exactly it is defined. I'd say that there was a bug that got fixed. There were consumers that relied on that bug so is it a BC break? 🤷🏾‍♀️

@ostrolucky
Copy link
Member

I agree. Sorry @nesl247.

@nesl247 nesl247 mentioned this issue Jun 22, 2022
Closed
Jean85 added a commit to facile-it/doctrine-mysql-come-back that referenced this issue Apr 1, 2023
@Jean85
Take attempts options from the primary configuration due to doctrine/…
05524c3 
…DoctrineBundle#1541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Won't Fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simPod @ostrolucky @nesl247