loading messenger services independent from ORM layer #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Aug 26, 2019
|
@unixslayer this is looking good, can you squash commits before I merge? Thanks! |
…t be required for messenger messenger services can be loaded before ORM since it's not requirement if $config['orm'] is not defined and $config['dbal'] is, ormLoad method should not be called phpcs fixes no need to check twice if ORM configuration is defined
|
@alcaeus done |
|
Superseded by #1028. Thanks @unixslayer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #997 Doctrine Messenger should not be dependent from ORM layer.