fix BC break for removed service alias

[dmaicher]

Fixes #1201

[NicoHaase]

Out of curiosity: is this a long-term fix, as in: we can expect that this service is kept longer, or will this be removed again in nearer future?

[dmaicher]

Out of curiosity: is this a long-term fix, as in: we can expect that this service is kept longer, or will this be removed again in nearer future?

I think we should keep this alias as long as we support doctrine/persistence < 2.0. What do you think @ostrolucky ?

[nicolas-grekas]

A quick release would be much appreciated, we're getting the same report on many repos.

[alcaeus]

Merged and released. Thanks @dmaicher.

[NicoHaase]

Should this "just fix everything that broke" ? Im between a rock and a hard place at the moment and cannot resolve it.

What does that mean? Is there any specific problem you are facing?

[ostrolucky]

I think we should keep this alias as long as we support doctrine/persistence < 2.0. What do you think @ostrolucky ?

Yep

[greg0ire]

I guess we should deprecate one in favor of the other. Not sure under which conditions exactly the new service is available/usable. It seems to be defined all the time, so… no condition?

[ostrolucky]

Users get deprecations when using common\persistence classes already, I don't think we need to do more there. They know they shoiuld not use them. In some future version of bundle that will drop support doctrine/common 1.x we will just also drop old aliases. By requiring doctrine/common 2.x we will guarantee nobody can use old classes anymore, hence also service aliases.