Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symfony uuid to a list of custom types as default uuid/ulid type #1207

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Add symfony uuid to a list of custom types as default uuid/ulid type #1207

merged 1 commit into from
Sep 7, 2020

Conversation

gennadigennadigennadi
Copy link
Contributor

As a result from symfony/symfony#37678, this PR is the last missing piece to implement symfony/uid as DoctrineTypes.

Copy link
Member

@ostrolucky ostrolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work with Symfony 4.4 that we need to support.

@gennadigennadigennadi
Copy link
Contributor Author

What about adding a check if the Pass is available then only add it if it is so?

@ostrolucky
Copy link
Member

Well of course. After that, you also need to revert composer.json changes

@ostrolucky ostrolucky added this to the 2.2.0 milestone Sep 7, 2020
@ostrolucky ostrolucky changed the title add RegisterUidTypePass Add symfony uuid to a list of custom types as default uuid/ulid type Sep 7, 2020
@ostrolucky ostrolucky merged commit 12833cd into doctrine:master Sep 7, 2020
@DavidBadura
Copy link

I am wondering if the automatic type registration can also be deactivated / prevented.

The background is that we use the Ramsey UUID Lib in many projects and want to stay with it. The doctrine type "uuid" is already defined by Ramsey Doctrine Extension. So you should have a conflict here, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants