Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1179 Deprecate doctrine:query:sql command #1231

Merged
merged 1 commit into from
Oct 25, 2020
Merged

#1179 Deprecate doctrine:query:sql command #1231

merged 1 commit into from
Oct 25, 2020

Conversation

ostrolucky
Copy link
Member

No description provided.

@ostrolucky ostrolucky added this to the 2.2.0 milestone Oct 18, 2020
@ostrolucky ostrolucky linked an issue Oct 18, 2020 that may be closed by this pull request
Console commands: compatiblity with upcoming doctrine/dbal 3.0 #1179
Closed
dmaicher
dmaicher reviewed Oct 20, 2020
View reviewed changes
Copy link
Contributor

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea to deprecate the doctrine:query:sql command completely and not just the old proxy class 😊

Tested it on one of my projects and found a few issues

Dbal/ManagerRegistryAwareConnectionProvider.php Show resolved Hide resolved
DependencyInjection/DoctrineExtension.php Outdated Show resolved Hide resolved
DependencyInjection/DoctrineExtension.php Outdated Show resolved Hide resolved
@ostrolucky ostrolucky merged commit fb5b10e into master Oct 25, 2020
@Chris53897 Chris53897 mentioned this pull request Mar 24, 2021
Merged
@greg0ire greg0ire deleted the feature-1179 branch June 3, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaicher dmaicher dmaicher left review comments

@stof stof Awaiting requested review from stof

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Console commands: compatiblity with upcoming doctrine/dbal 3.0
2 participants
@ostrolucky @dmaicher