Fix #1314, shard manager class option cannot be overridden #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberemissary
force-pushed
the
fix-shard_manager_class
branch
from
ee29309
to
78e5625
Compare
ostrolucky
requested changes
Mar 29, 2021
cyberemissary
force-pushed
the
fix-shard_manager_class
branch
from
78e5625
to
6da081e
Compare
ostrolucky
reviewed
Mar 29, 2021
cyberemissary
force-pushed
the
fix-shard_manager_class
branch
from
6da081e
to
f331da8
Compare
ostrolucky
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that does not allow to override the shard_manager_class
Closes #1314