Allow doctrine/persistence 3
#1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Psalm failure is unrelated: Psalm runs on PHP 7.1 in our CI while Persistence 3 requires PHP >= 7.2. |
|
I've tried locally and get the same failures on the 2.6.x branch. They're probably related to the ORM 2.12 and Persistence 2.5 releases. |
|
If you have time, would be greater to fix those, even though it might be unrelated to this PR |
derrabus
force-pushed
the
bugfix/persistence-3
branch
from
c30fd9f
to
f1463dd
Compare
|
Fixed in #1511 |
dmaicher
approved these changes
Apr 22, 2022
ostrolucky
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.