Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for unmaintained Symfony versions #1539

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

dmaicher
Copy link
Contributor

Some of those versions are long dead. So I think we can clean up a bit?

@dmaicher
Copy link
Contributor Author

Whats our policy for bumping requirements? fine for a patch release? Or should be a minor?

@dmaicher dmaicher marked this pull request as ready for review June 20, 2022 18:14
@ostrolucky
Copy link
Member

ostrolucky commented Jun 20, 2022

Well I generally avoid bumping if I can't have benefit from it, eg. in form of getting rid of some BC code. I like when requirements truthfully say which version are actually required and are not just periodically bumped for political reasons. But since multiple people asked about this already, I don't think it's such a big deal. I think it was even pointed out before that test suite is not even testing these, because even --prefer-lowest doesn't install lowest constraints,since they are blocked by some other dependencies.

As for patch/minor, I don't think we have a policy for this. As for me, I don't care in this instance.

@dmaicher dmaicher added this to the 2.7.1 milestone Jun 20, 2022
@ostrolucky
Copy link
Member

Feel free to rebase, we can merge afterwards

@dmaicher dmaicher merged commit 59c101a into doctrine:2.7.x Jun 22, 2022
@dmaicher dmaicher deleted the drop_sf_versions branch June 22, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants