Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Composer Lint" job to CI pipeline #1540

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Jun 21, 2022

Applies composer-lint workflow from doctrine/.github.

@phansys phansys marked this pull request as ready for review June 21, 2022 00:26
Copy link
Member

@ostrolucky ostrolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ostrolucky
Copy link
Member

Hmm maybe we should have this in https://github.com/doctrine/.github/blob/main/.github/workflows/coding-standards.yml so it applies for all projects, cc @greg0ire

@ostrolucky ostrolucky requested a review from greg0ire June 21, 2022 10:50
@greg0ire
Copy link
Member

I think it could indeed be contributed to that repo. If we add it to the CS workflow. If we do that, the next release should probably be 2.0.0 to make it clear that an action must be taken to make the build green (fixing composer.json). It would be great to make this workflow kick in only when appropriate, using paths, otherwise it will mean one more job per project, and a job that is unlikely to fail when composer.json is not touched.

stof
stof previously requested changes Jun 22, 2022
.github/workflows/coding-standards.yml Outdated Show resolved Hide resolved
@greg0ire greg0ire marked this pull request as draft June 22, 2022 10:38
@phansys phansys marked this pull request as ready for review June 22, 2022 13:25
@phansys phansys requested a review from greg0ire June 22, 2022 13:25
@phansys phansys changed the title Add "Lint Composer" job to CI pipeline Add "Composer Lint" job to CI pipeline Jun 22, 2022
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@greg0ire greg0ire dismissed stof’s stale review June 22, 2022 16:29

review has been addressed

@greg0ire greg0ire requested a review from ostrolucky June 22, 2022 16:29
@ostrolucky ostrolucky merged commit 2261374 into doctrine:2.7.x Jun 22, 2022
@phansys phansys deleted the composer_lint branch June 22, 2022 17:36
@derrabus derrabus added the CI label Nov 1, 2022
@derrabus derrabus added this to the 2.7.1 milestone Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants