Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resetting lazy managers on Symfony 6.2 #1545

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

nicolas-grekas
Copy link
Member

Sidekick of symfony/symfony#46752

@ostrolucky
Copy link
Member

I've fixed flex issue in 2.7 branch, can you rebase please (some CI matrices will still fail due to unrelated issue with DBAL, but at least some should succeed).

@nicolas-grekas
Copy link
Member Author

Looks like I need to have a closer look at failures.

nicolas-grekas added a commit to symfony/symfony that referenced this pull request Jul 13, 2022
…etrized class (nicolas-grekas)

This PR was merged into the 6.2 branch.

Discussion
----------

[DependencyInjection] Fix dumping lazy services with parametrized class

| Q             | A
| ------------- | ---
| Branch?       | 6.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

The class of lazy services is currently not resolved. This has never been an issue before, but it's going to be one on 6.2 since services are now lazy even if proxy-manager-bridge is not installed.

Spotted while working on doctrine/DoctrineBundle#1545, which needs this patch.

Commits
-------

2ef04e9 [DependencyInjection] Fix dumping lazy services with parametrized class
@nicolas-grekas
Copy link
Member Author

Green after symfony/symfony#46929
Help wanted for the psalm failure.
I'm on vacation starting today, feel free to push on my fork if needed.
You might need to borrow (part of) the patch to fix the builds on lower maintained branches.

@ostrolucky ostrolucky merged commit 48ec718 into doctrine:2.7.x Jul 13, 2022
@nicolas-grekas nicolas-grekas deleted the ve-lazy branch July 13, 2022 21:17
@ostrolucky ostrolucky added this to the 2.7.1 milestone Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants