Make ServiceEntityRepository lazy on Symfony 6.2+ #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
changed the title
|
Closing in favor of #1600 |
|
Reopening as discussed in #1600 |
|
tests should be fixed |
nicolas-grekas
force-pushed
the
lazy-service-repo
branch
4 times, most recently
from
c31d200
to
247579f
Compare
|
How can I tell psalm to ignore the missing trait? |
nicolas-grekas
force-pushed
the
lazy-service-repo
branch
2 times, most recently
from
c2cffdc
to
a979476
Compare
nicolas-grekas
force-pushed
the
lazy-service-repo
branch
from
a979476
to
5546ade
Compare
|
Tests are green but psalm+cs are red. |
|
I'll fix CS + SA |
ostrolucky
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed ignoring whitespaces.
See symfony/symfony#48666 for background.