Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tabs to profiler UI. #1609

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Add tabs to profiler UI. #1609

merged 1 commit into from
Jan 6, 2023

Conversation

nickygerritsen
Copy link
Contributor

This adds tabs to the Doctrine profiler, based on #1558 and #1607. Best to ignore whitespace when viewing the PR.

Some remarks:

  • Titles of sections have been removed since they are now in the tab title.
  • I added an empty check to the queries tab so it shows something nice if there are no queries.
  • Tabs are disabled if they don't have any (useful) content (but you can still click disabled tabs).

Screenshot time!

Before on 6.1:
image

Now on 6.1:
image

Before on 6.2:
image

Now on 6.2:
image

@nickygerritsen nickygerritsen changed the title Update Profiler UI for Symfony 6.2+. Add tabs to profiler uI. Jan 6, 2023
@nickygerritsen nickygerritsen changed the title Add tabs to profiler uI. Add tabs to profiler UI. Jan 6, 2023
@ostrolucky ostrolucky added this to the 2.9.0 milestone Jan 6, 2023
@ostrolucky ostrolucky merged commit ee37cac into doctrine:2.9.x Jan 6, 2023
@nickygerritsen nickygerritsen deleted the profiler-tabs branch January 6, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostrolucky ostrolucky ostrolucky approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickygerritsen @ostrolucky