Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect unused psalm-suppress annotations #1617

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

greg0ire
Copy link
Member

This repository seems to be relying on psalm-suppress a lot (unlike other repositories).

@ostrolucky
Copy link
Member

Oh I thought this is a default 👍 Feel free to remove

@greg0ire
Copy link
Member Author

Will do, just wanted to see it run on php 7.4 with everything that implies regarding what gets installed

This repository seems to be relying on psalm-suppress a lot (unlike
other repositories).
@greg0ire greg0ire marked this pull request as ready for review January 13, 2023 19:54
@ostrolucky ostrolucky merged commit a1cd824 into doctrine:2.8.x Jan 13, 2023
@greg0ire greg0ire deleted the find-unused-psalm-supress branch January 13, 2023 20:24
@greg0ire greg0ire added the CI label Jan 13, 2023
@greg0ire greg0ire changed the title Detect unused psalm-suppress annotation Detect unused psalm-suppress annotations Jan 13, 2023
@greg0ire greg0ire added this to the 2.8.3 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants