Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify EntityValueResolver as ValueResolver #1624

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

MatTheCat
Copy link
Contributor

Follow-up of symfony/symfony#48992: a new ValueResolver attribute can be attached to a parameter to specify which resolver will yield its value. This PR will allow to write

#[ValueResolver(EntityValueResolver::class)]

(The used syntax allowing to add a name attribute to a tag has been introduced in symfony/dependency-injection 5.1 by symfony/symfony#36586. This is not a problem since we require ^5.4 || ^6.0.)

@MatTheCat MatTheCat changed the base branch from 2.8.x to 2.9.x January 27, 2023 08:09
@ostrolucky ostrolucky added the Status: On Hold Most likely waiting for upstream resolution label Jan 31, 2023
@ostrolucky ostrolucky added this to the 2.9.0 milestone Jan 31, 2023
@ostrolucky ostrolucky merged commit 33037fd into doctrine:2.9.x Feb 23, 2023
@MatTheCat MatTheCat deleted the entity_value_resolver-name branch February 23, 2023 10:49
@dmaicher dmaicher removed the Status: On Hold Most likely waiting for upstream resolution label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants