Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve DoctrineDataCollectorTest and fix some deprecations #1633

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

dmaicher
Copy link
Contributor

Fixes

Remaining self deprecation notices (1)

  1x: Method "Symfony\Bridge\Doctrine\DataCollector\DoctrineDataCollector::collect()" might add "void" as a native return type declaration in the future. Do the same in child class "Doctrine\Bundle\DoctrineBundle\DataCollector\DoctrineDataCollector" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in DoctrineDataCollectorTest::testCollectEntities from Doctrine\Bundle\DoctrineBundle\Tests\DataCollector

Remaining indirect deprecation notices (2)

  1x: Passing an instance of Doctrine\ORM\Mapping\ClassMetadataInfo to Doctrine\ORM\Tools\SchemaValidator::validateClass is deprecated, please pass a ClassMetadata instance instead. (SchemaValidator.php:82 called by DoctrineDataCollector.php:116, https://github.com/doctrine/orm/pull/249, package doctrine/orm)
    1x in DoctrineDataCollectorTest::testCollectEntities from Doctrine\Bundle\DoctrineBundle\Tests\DataCollector

  1x: DebugStack is deprecated. (DebugStack.php:41 called by Generator.php:715, https://github.com/doctrine/dbal/pull/4967, package doctrine/dbal)
    1x in DoctrineDataCollectorTest::testGetGroupedQueries from Doctrine\Bundle\DoctrineBundle\Tests\DataCollector

psalm.xml.dist Outdated Show resolved Hide resolved
@dmaicher dmaicher marked this pull request as ready for review February 27, 2023 20:16
@ostrolucky ostrolucky added this to the 2.9.0 milestone Feb 27, 2023
@dmaicher dmaicher merged commit 4a268d6 into doctrine:2.9.x Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants