Fix all deprecations #1634
Fix all deprecations #1634
Conversation
|
@greg0ire I might need some help to figure out how to resolve this one I had a look at doctrine/orm#6728 and figured out that we seem to be using https://github.com/doctrine/orm/blob/2.14.x/lib/Doctrine/ORM/Mapping/Driver/SimplifiedXmlDriver.php#L23 So I cannot really get rid of this deprecation easily, or? |
dmaicher
force-pushed
the
fix_deprecations
branch
2 times, most recently
from
54b0acd
to
f5756ac
Compare
|
Well, looks like the ORM forgot to update the constructor of the SimplifiedXmlDriver to expose the boolean argument added in the parent |
|
@Kern046 can you please take a look at this simplified xml driver stuff? I'm AFK now and for a few more days I think. |
| @@ -59,7 +59,7 @@ private function updateSecondLevelCache(ContainerBuilder $container, Definition | |||
| $factoryDefinition = $methodCall[1][0]; | |||
| assert($factoryDefinition instanceof Definition); | |||
| $aliasId = (string) $factoryDefinition->getArgument(1); | |||
| $this->wrapIfNecessary($container, $aliasId, (string) $container->getAlias($aliasId), false); | |||
| $this->wrapIfNecessary($container, $aliasId, (string) $container->getAlias($aliasId), true); | |||
There was a problem hiding this comment.
second level also supports PSR6 caches since ORM 2.11 (which we require). See doctrine/orm#9322
dmaicher
force-pushed
the
fix_deprecations
branch
from
89d0929
to
6344ef9
Compare
dmaicher
force-pushed
the
fix_deprecations
branch
from
0be7634
to
208310a
Compare
dmaicher
force-pushed
the
fix_deprecations
branch
from
208310a
to
988a408
Compare
| // enable validation | ||
| $args[] = true; | ||
|
|
||
| $xmlDriverDef->setArguments($args); |
There was a problem hiding this comment.
@stof can we move this to symfony/doctrine-bridge instead? I mean that bridge is the one that specifies constructor args there. I am just not sure if symfony folks are ok to enable strict xml validation with symfony 6.3. If not, we will do it here but end result will be same.
All deprecations are fixed now 馃槉