Hacking in support for dbal result cache #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,7 +59,7 @@ | |||
| </xsd:choice> | |||
|
|
|||
| <xsd:attribute name="default-connection" type="xsd:string" /> | |||
| <xsd:attributeGroup ref="connection-config" /> | |||
| <xsd:attribute name="connection-config" type="connection-config" /> | |||
There was a problem hiding this comment.
This is wrong. You cannot have an attribute being a complexType.
|
btw, there is issues with your changes in the XSD. See the testsuite failures. |
|
I expect there are numerous flaws in this PR, as it's a cheap hack to the PHP lib, with a failed attempt to update the xsd (without real understanding on my part regarding valid XSD schema). I'd never suggest anyone ever use this code either, except to perhaps see possible entry points for refactoring to support DBAL cache :-) Hopefully someone else will get inspired, as I'm slammed with a late deadline for the next several weeks :-\ |
|
You can add this kind of code with a compiler pass if you need it for your application. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #114
This is hacked-in support. Some of the code may be usable, but really this shows that some refactoring is needed so that cache support isn't limited to ORM only.
Please do not merge in this code, just submitting it so that others can see where modifications are needed and run with it. I pretty much have no clue re: the XSD changes, but I didn't get any errors out of Symfony2 or PHPStorm with my changes. Regardless, even the XSD changes need refactoring, as the cache type definitions should be moved into a reusable location in the schema imho (so that it's accessible by both dbal and orm namespaces).
Also, this has only been tested with Service type cache instance. I don't have the time to attempt this proper.