Expose the XSD validation in the DoctrineOrmMappingsPass #1679
Conversation
| { | ||
| $locator = new Definition(SymfonyFileLocator::class, [$namespaces, '.orm.xml']); | ||
| $driver = new Definition(XmlDriver::class, [$locator]); | ||
| $driver = new Definition(XmlDriver::class, [$locator, null, $enableXsdValidation]); |
There was a problem hiding this comment.
In the previous situation, we were omitting the second argument. I think as a result, XmlDriver::DEFAULT_FILE_EXTENSION was used: https://github.com/doctrine/orm/blob/55d477dc507a52675c5a61267a00d389c71182f4/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php#L50
| $driver = new Definition(XmlDriver::class, [$locator, null, $enableXsdValidation]); | |
| $driver = new Definition(XmlDriver::class, [$locator, XmlDriver::DEFAULT_FILE_EXTENSION, $enableXsdValidation]); |
If I don't sound very sure about this, that's because its value is .dcm.xml, and I don't recall ever seeing that extension in Symfony projects. Also, on line 71, .orm.xml is mentioned so maybe it takes over somehow?
There was a problem hiding this comment.
The extension argument of the driver is ignored when passing a locator anyway. It is used only when passing a path.
And the locator we use uses the default extension of the simplified driver, which is not the same, so it would be confusing.
Closes #1647
This allows bundles registering a custom mapping through the DoctrineOrmMappingsPass to opt-in for the XSD validation, which was forgotten when adding support for this opt-in in other places in the bundle.