New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update priority of built-in middleware #1760
Update priority of built-in middleware #1760
Conversation
Nature of this is dubious, plus potentially BC breaking. Targetting 2.11.x. Not sure it should have prio 100 either, that's quite high. Something like |
@ostrolucky yes it can be 10, I was not sure about the number. Why do you think it's dubious ? |
Because doctrine-bundle never claimed to log everything, including custom middlewares. For some people it might be intended that queries in custom middlewares are not logged. |
@ostrolucky it makes sense 👍 So I close it, thank you for your feedback :) |
Well I agree with the change, my only argument was to not classify this as a bugfix, which I did ;) |
But there is also the BC break problem, isn't it ? |
It's a potential break for someone. But middleware priorities is not something we promise not to change. |
@ostrolucky ok I see 👍 I reopened it with the priority set to 10. Thank you for your feedbacks :) |
eebaeec
to
58e0119
Compare
With the default priority, middlewares for logging and profiler don't see the eventual query changes performed by userland middlewares (that have by default a priority of 0)
58e0119
to
0128804
Compare
With the default priority, middlewares for logging and profiler don't see the eventual query changes performed by userland middlewares (that have by default a priority of 0)