Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing more headers #751

Merged
merged 1 commit into from Dec 18, 2017
Merged

Removing more headers #751

merged 1 commit into from Dec 18, 2017

Conversation

mikeSimonson
Copy link
Contributor

No description provided.

@mikeSimonson mikeSimonson merged commit 4ab04c0 into master Dec 18, 2017
@stof stof deleted the license-clean-more branch December 18, 2017 10:46
@kimhemsoe kimhemsoe added this to the 1.8.2 milestone Dec 18, 2017
@sroze
Copy link
Contributor

sroze commented Jan 11, 2018

What's the reasoning behind it?

@mikeSimonson
Copy link
Contributor Author

@Majkl578
Copy link
Contributor

@sroze Also to quote the license itself:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

This requirement is fulfilled by the LICENSE file in the root which is part of Composer/ZIP distribution or GitHub forks. Should anyone copy any part of the library (i.e. single class) to their code, it's their responsibility to retain copyright, not the vendor's.
From the maintainer's point of view, it's unnecessary extra work to keep it in sync, plus it's 17 lines of boilerplate in each file (~7700 lines in ORM for example).

@sroze
Copy link
Contributor

sroze commented Jan 11, 2018

Fair enough, thanks for your answer 👍

@kimhemsoe kimhemsoe modified the milestones: 1.8.2, 1.9.0 Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants