Allow to typehint ConnectionRegistry
#936
Conversation
| @@ -64,6 +64,7 @@ | |||
| <argument>%doctrine.default_entity_manager%</argument> | |||
| </service> | |||
| <service id="Doctrine\Common\Persistence\ManagerRegistry" alias="doctrine" public="false" /> | |||
| <service id="Doctrine\Common\Persistence\ConnectionRegistry" alias="doctrine" public="false" /> | |||
There was a problem hiding this comment.
I'm very much against adding more interfaces from doctrine/persistence and tying them to ORM. Existing aliases will be dropped in 2.0, see #870. Do we have other options here?
There was a problem hiding this comment.
Another bundle? :/ What's the reasoning behind not having interfaces from doctrine/persistence in this bundle? 🤔 If ORM changes and doctrine is not anymore the service holding the ConnectionRegistry anymore, we "just" have to release a new version of this bundle isn't it?
There was a problem hiding this comment.
ORM isn’t the only mapper. The surrounding interfaces will be removed in 2.0 as the assumption that any interface from persistence should be owned by ORM goes out the door once another mapper (e.g. MongoDB ODM) is used.
There was a problem hiding this comment.
We solved this in general up until now by having an sub-interface that’s ORM-only iirc.
But if that doesn’t exist, it is tricky: not using these interfaces for autowiring optimizes for the 1% that use ORM and ODM simultaneously.
We could use the named autowiring thing that was added in 4.2 to make it ConnectionRegistry $dbalRegistry (where you need the type + arg name to match)
There was a problem hiding this comment.
We could use the named autowiring thing that was added in 4.2 to make it ConnectionRegistry $dbalRegistry (where you need the type + arg name to match)
But it wouldn't be a good DX for the 99% :/
|
Could the user instead already use the RegistryInterface from the Symfony Bridge to get the connection? |
|
Yes, the ConnectionRegistry interface is extended by the ManagerRegistry interface, so this shouldn’t be too much of a problem. @sroze did you have a particular use-case for adding this? |
|
Just wanted to get a connection by its name so thought I had to inject |
|
Good to see it worked. I'll take a look at ConnectionRegistry and how to proceed with it. Closing here in the meantime. |
This would allow to typehint the
ConnectionRegistryinterface to be able to get a connection.